fix(diff): avoid cache miss in server-side diff (#20423) #20424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
crenshaw-dev
commented
Oct 17, 2024
| @@ -1056,15 +1056,15 @@ func (a *ApplicationStatus) GetRevisions() []string { | |||
|
|
|||
| // BuildComparedToStatus will build a ComparedTo object based on the current | |||
| // Application state. | |||
| func (app *Application) BuildComparedToStatus() ComparedTo { | |||
| func (spec *ApplicationSpec) BuildComparedToStatus() ComparedTo { | |||
There was a problem hiding this comment.
Scoped this down since we don't need access to the whole app. Makes it easier to avoid doing a DeepCopy on the whole app in specEqualsCompareTo
Signed-off-by: Michael Crenshaw <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20424 +/- ##
==========================================
- Coverage 56.05% 55.07% -0.99%
==========================================
Files 322 322
Lines 44802 54927 +10125
==========================================
+ Hits 25115 30252 +5137
- Misses 17084 22077 +4993
+ Partials 2603 2598 -5 ☔ View full report in Codecov by Sentry. |
agaudreault
reviewed
Oct 18, 2024
| @@ -947,6 +945,25 @@ func useDiffCache(noCache bool, manifestInfos []*apiclient.ManifestResponse, sou | |||
| return true | |||
| } | |||
|
|
|||
| // specEqualsCompareTo compares the application spec to the comparedTo status. It normalizes the destination to match | |||
| // the comparedTo destination before comparing. It does not mutate the original spec or comparedTo. | |||
| func specEqualsCompareTo(spec v1alpha1.ApplicationSpec, comparedTo v1alpha1.ComparedTo) bool { | |||
There was a problem hiding this comment.
Could be ptr arguments, but I dont think performance will increase that much.
Suggested change
| func specEqualsCompareTo(spec v1alpha1.ApplicationSpec, comparedTo v1alpha1.ComparedTo) bool { | |
| func specEqualsCompareTo(spec *v1alpha1.ApplicationSpec, comparedTo *v1alpha1.ComparedTo) bool { |
|
/cherry-pick release-2.13 |
|
/cherry-pick release-2.12 |
|
/cherry-pick release-2.10 |
|
/cherry-pick release-2.11 |
|
Cherry-pick failed with |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(diff): avoid cache miss in server-side diff (#20423) Signed-off-by: Michael Crenshaw <[email protected]> * fix silly mistakes Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(diff): avoid cache miss in server-side diff (#20423) Signed-off-by: Michael Crenshaw <[email protected]> * fix silly mistakes Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
This was referenced Oct 18, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(diff): avoid cache miss in server-side diff (#20423) Signed-off-by: Michael Crenshaw <[email protected]> * fix silly mistakes Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 18, 2024
…0449) * fix(diff): avoid cache miss in server-side diff (#20423) * fix silly mistakes --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 18, 2024
…0450) * fix(diff): avoid cache miss in server-side diff (#20423) * fix silly mistakes --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 18, 2024
…0451) * fix(diff): avoid cache miss in server-side diff (#20423) * fix silly mistakes --------- Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20423